Update Reader icons to Gridicons and universal vector assets...

来自 : CSDN技术社区 发布时间：2021-03-25

私信 访问主页

weixin_39736650 2021-01-08 05:52 首页 开源项目 Update Reader icons to Gridicons and universal vector assets.

Updates icons used in the reader to Gridicons and universal vector PDF assets.

Removed, replaced with gravatar (default user image):- default-identicon- gravatar-reader

Removed, replaced with post-blavatar-placeholder (default site icon):- icon-feed

Updated:- background-comment-nesting- background-reader-tear- gravatar- icon-clear-textfield- icon-posts-share- icon-reader-comment-highlight- icon-reader-comment-like- icon-reader-comment-liked- icon-reader-comment-reply- icon-reader-comment- icon-reader-follow-highlight- icon-reader-follow- icon-reader-following- icon-reader-header-list- icon-reader-header-tag- icon-reader-like-highlight- icon-reader-like- icon-reader-liked- icon-reader-search-plus

background-comment-nesting.png included a background color that doesn t match the background color of the app (see screenshot below). Its replacement, background-comment-nesting.pdf uses a transparent background instead. Let me know if anyone knows why/if we shouldn t use a transparent background for the comment nesting image.

Reader Comments, before (left) and after (right). Includes gravatar replacing default-identicon; updated icon-reader-comment-like, icon-reader-comment-liked, icon-reader-comment-reply, background-comment-nesting.

Updated to use Gridicons:

icon-posts-share

icon-clear-textfield, icon-reader-search-plus

All other icons have been updated to vector PDF assets but are visually the same as before.

Needs Review:

该提问来源于开源项目 wordpress-mobile/WordPress-iOS

点赞 写回答 收藏 复制链接分享 删除 再等等 结题 再想想 7条回答

私信 访问主页

weixin_39736650 2月前

Not sure if that s something to tackle here or in a separate PR

Good catch, I noticed a handful of places like that while I was replacing icons. I think it would make sense to open a new issue to look at highlighted states in a cohesive way around the app -- I noticed that in some places we use a special -highlighted image, and in others we simply darken the existing one, and it would be nice to make that consistent everywhere.

点赞 评论 复制链接分享

私信 访问主页

weixin_39531761 2月前

Awesome. Took things for a test drive and they look great! One thing that caught my eye (and this was already the case before, doH!) was that we don t have a jazzy orange version of the reply icon for its highlight state. When tapped it does this: Not sure if that s something to tackle here or in a separate PR. If we want to wait then this one is ready to :shipit:

点赞 评论 复制链接分享

私信 访问主页

weixin_39736650 2月前

Hmm. Looks like icon-reader-comment-highlighted.pdf and icon-reader-comment.pdf got mismatched. But the way they were assigned in code was also reversed which canceled out the issue. :) Could we swap things around so the naming matches the use?

Whoops! That was strange. Looks like I mis-named the assets but dropped them into the right place in Xcode. :) Fixed up in 997fee8.

点赞 评论 复制链接分享

私信 访问主页

weixin_39736650 2月前

Transparencies degrade scrolling performance so we want to avoid them for those use cases.

Thanks -- I thought there might be something like that at play. In 1fa67f8 I ve updated background-comment-nesting.pdf to include a greyLighten30 background so it matches the page below and still solves #4433.

点赞 评论 复制链接分享

私信 访问主页

weixin_39531761 2月前

Hmm. Looks like icon-reader-comment-highlighted.pdf and icon-reader-comment.pdf got mismatched. But the way they were assigned in code was also reversed which canceled out the issue. :) Could we swap things around so the naming matches the use?

点赞 评论 复制链接分享

私信 访问主页

weixin_39531761 2月前

This PR will close #4433

点赞 评论 复制链接分享

私信 访问主页

weixin_39531761 2月前

Nice !

Let me know if anyone knows why/if we shouldn t use a transparent background for the comment nesting image.

Transparencies degrade scrolling performance so we want to avoid them for those use cases.

点赞 评论 复制链接分享 提交 再想想 采纳 为你推荐 vue项目中使用tinymce编译器时工具栏图标不显示，功能可以正常使用，这是什么问题？ vue.js 3个回答转到Web服务器：在http：// localhost：8080 / handler上找不到任何内容 webserver 1个回答如何在golang中设置应用程序图标？ icons 3个回答树枝模板中的SVG图标 svghtmliconsphp 1个回答HTML电子邮件图像在Outlook中正常工作但在Outlook.com中没有 htmloutlookphp 1个回答是否可以编辑TYPO3的后端？ typo3php 1个回答Wordpress插件 - 如何更改图标？ javascripticonswordpressphp 1个回答如何在php for循环中生成动态字体真棒图标 font-awesomephp 4个回答Zend验证码图像生成空白 captchaphp 2个回答jQuery更改ID than $（this）.attr（“id”）的所有DIV的ID; htmljavascriptphpjquery 1个回答laravel 5删除方法。 始终在RouteCollection.php第233行中的MethodNotAllowedHttpException： laravelphp 4个回答从example.com/script.php?param=value到example.com/value的Nginx重写 url-rewritingphpnginx 2个回答PHP exec_shell使用unrar.exe php 1个回答使用htaccess和PHP拒绝目录和文件访问 apacheredirectphp 1个回答Symfony 3无法找到我的.svg图标 svghtmlsymfonyphp 2个回答nginx（MAMP）在index.php上返回404 mampphpnginx 1个回答我的manifest.json出了什么问题 jsonphp 1个回答Cakephp图像未显示在view.ctp中 javascriptphp 2个回答将ORDER BY语法附加到php MySQL查询 mysqlphp 2个回答Google Material Icons as array - 任何想法？ arraysphp 2个回答 点击登录 提问题 欢迎建议意见 . 如何写高质量提问和回答？ 采纳榜7天 被采纳次数 ProfSnail 25 幻灰龙 19 qq_34124780 154 coagenth 115 规则边缘 116 GoCityPass新加坡曼谷通票 117 cpp_learner 98 Jack_Yang(数据分析及可视化) 99 我不喜欢这个世界 810 天际的海浪 6 加急问题 500 500 基于tensorflow的模型做预测时，cpu占用率过高，如何降低程序的cpu占用率？ 100 unity 设置Animation的culling type 导致游戏崩溃 100 java实现下面两个算法 100 ECDSA加密算法中，签名和验证都是需要时间的，那其时间复杂度怎么用椭圆曲线参数如阶或模p来表示呢？ 75 数据库只有myd文件没有frm,myi文件，怎么打开呢 51 利用Adams联合matlab仿真求运动学反解问题 50 labview使用datasocket与c/c#程序的通信 50 python引用xlwings出问题，这个报错什么意思 ，怎么解决，谢谢大佬 50 如何用C语言实现凯撒密码对文本文件(.txt)的读取穷举暴力破解？ 50 已知地图GPS坐标点A和坐标点B，获取A点往B点直线走一定距离的坐标点经纬度？